Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore clippy new_without_default #513

Merged
merged 1 commit into from
May 26, 2024
Merged

Ignore clippy new_without_default #513

merged 1 commit into from
May 26, 2024

Conversation

Thomasdezeeuw
Copy link
Collaborator

Not needed for TcpKeepalive.

@Thomasdezeeuw
Ignore clippy new_without_default
7f67fbb 
Not needed for TcpKeepalive.
Darksonn
Darksonn approved these changes May 26, 2024
View reviewed changes
Copy link
Collaborator

@Darksonn Darksonn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You sure you don't want to just add a Default impl that calls new?

@Thomasdezeeuw
Copy link
Collaborator Author

You sure you don't want to just add a Default impl that calls new?

If someone needs it we can consider it, but for now it's just more API surface we would have to maintain.

@Thomasdezeeuw Thomasdezeeuw merged commit 6a13053 into rust-lang:master May 26, 2024
41 checks passed
@Thomasdezeeuw Thomasdezeeuw deleted the ignore-clippy branch May 26, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thomasdezeeuw @Darksonn